DM-14004: Make astshim compliant with the -pedantic compiler flag #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
requested changes
Apr 5, 2018
include/astshim/detail/utils.h
Outdated
| delete[] array; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
This is not safe at present; if you copy this object, array will get deleted twice.
I think the best way to fix that is to use unique_ptr<char[]> (see http://en.cppreference.com/w/cpp/memory/unique_ptr/operator_at), which is probably simple enough that you don't need a separate class.
There was a problem hiding this comment.
Excellent suggestion. I implemented that. Please review again.
char * array[nchar]; is not C++ compliant and fails to build with the -pedantic compiler flag, so use std::unique_ptr<char[]> instead.
both by scons (add setup.cfg and tweak tests/SConscript) and Travis on github (add .travis.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.