Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42065: Move Object::getI into library body #65

Merged
merged 1 commit into from Dec 9, 2023
Merged

Conversation

mwittgen
Copy link
Contributor

@mwittgen mwittgen commented Dec 7, 2023

No description provided.

src/Object.cc Outdated Show resolved Hide resolved
Copy link

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why it's not necessary to move other similar methods like getD, but if this works it's fine with me to forward as is.

@mwittgen
Copy link
Contributor Author

mwittgen commented Dec 8, 2023

I'm curious why it's not necessary to move other similar methods like getD, but if this works it's fine with me to forward as is.

There might be more methods. If the member function defined in the astshim header
generates no references to ast, it can stay
defined in the header. Or if the including code does not use a member function from the
astshim header fille.

@mwittgen mwittgen merged commit 50ff169 into main Dec 9, 2023
2 checks passed
@mwittgen mwittgen deleted the tickets/DM-42065 branch December 9, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants