DM-35771: Remove gen2 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfisherlevine I'm assuming that |
|
There is also the makeFakeFlats.py script that is using gen2. Should that be deleted or ported? |
Does require that the extraction file is retrievable from a butler. It no longer attempts to find a filename to read explicitly.
Does need daf_butler and does not need the library path env vars.
The metadata translator already knows how to deal with different header variants for LATISS data.
Storing things that do match seems easier than storing things that don't match and then having to filter them out the list later.
This leaves the ordering up to the caller rather than trying to decide whether the self.seqNums will always be sorted.
Jim Bosch advises we be defensive and remove them just in case queryDimensionRecords changes how it works in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.