DM-37552: Remove unnecessary import of lsstimport #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Apr 14, 2023
| @@ -20,7 +20,7 @@ | |||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | |||
|
|
|||
| import pkgutil | |||
There was a problem hiding this comment.
@mfisherlevine We don't usually put pkgutil imports at this level so I'm wondering whether it should be here given there aren't any external subpackages in the lsst.atmospec namespace.
There was a problem hiding this comment.
Fair enough, and looks like it's already merged, so 👍
There was a problem hiding this comment.
I merged the lsstimport change yes. I wasn't sure what your intent was with the pkgutil line. I think it's only needed if you are going to have atmospec_x and atmospec_y packages.
There was a problem hiding this comment.
None - it was almost certainly cargo-culted that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.