DM-38744: Add auto option for how main star centroid is picked #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Apr 18, 2023
python/lsst/atmospec/processStar.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| inputCentroid : `???` |
There was a problem hiding this comment.
dict with no further information is better than nothing here.
There was a problem hiding this comment.
lol, yeah, that wasn't intentional, sorry 😄
| self.log.info("Auto centroid is using FIT in Spectractor to get the target centroid") | ||
| return 'fit' # this means exact | ||
|
|
||
| # this is just renaming the config parameter because guess sounds like |
There was a problem hiding this comment.
This is confusing, but from this comment and those above, it seems that is just how it is.
There was a problem hiding this comment.
Yup, it's very confusing, hence choosing to rename it for us. I can negotiate renaming with Jérémy, but given we rename basically all the spectractor parameters into task config options, changing some of the values too doesn't feel so bad. I'll have a chat with him and if he agrees we can take it out in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.