DM-41500: Update to Spectractor v3.0.2 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.0.2 has both an updated area calculation, which this is updating to match, and also a change in units from m^2 to cm^2. Removes now-unused OBS_DIAMETER parameter.
Adds config options for transmissionSystematicError and instrumentTransmissionOverride.
jeremyneveu
reviewed
Oct 31, 2023
python/lsst/atmospec/processStar.py
Outdated
| @@ -310,7 +310,7 @@ class ProcessStarTaskConfig(pipeBase.PipelineTaskConfig, | |||
| dtype=int, | |||
| doc="Half transverse width of the signal rectangular window in pixels. " | |||
| "PIXWIDTH_SIGNAL internally.", | |||
| default=40, | |||
| default=20, | |||
There was a problem hiding this comment.
This should be 40 pixels by default (works better).
czwa
approved these changes
Oct 31, 2023
| @@ -860,11 +874,10 @@ def run(self, *, inputExp, inputCentroid, dataIdDict): | |||
| 'OBS_NAME': 'AUXTEL', | |||
There was a problem hiding this comment.
Why don't these inherit from the auxtel.ini values? I see they're "Hard coded," but I'm curious why these are special.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.