Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10384: Add macro for forcing hidden visibility. #31

Merged
merged 1 commit into from Oct 1, 2018
Merged

DM-10384: Add macro for forcing hidden visibility. #31

merged 1 commit into from Oct 1, 2018

Conversation

TallJimbo
Copy link
Member

No description provided.

parejkoj
parejkoj approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting in the docstring that this is for pybind11 mostly?

@TallJimbo
Copy link
Member Author

I'm actually hoping someday it might not just be for pybind11, but that too is better said in the docstring as well.

@TallJimbo TallJimbo merged commit 1e9226d into master Oct 1, 2018
@TallJimbo TallJimbo deleted the tickets/DM-10384 branch October 1, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TallJimbo @parejkoj