DM-25431: Include conda environment in package version detection #45
Conversation
| @@ -278,6 +327,7 @@ def fromSystem(cls): | |||
| packages : `Packages` | |||
| """ | |||
| packages = {} | |||
| packages.update(getCondaPackages()) | |||
There was a problem hiding this comment.
You mentioned a slowdown, does fromSystem need to be cached in some way? Or is generally processed once per process?
There was a problem hiding this comment.
We only expect this to be called once but on the other hand we can be pretty confident that it's not going to change whilst this process is running. It might be best to add some lru_cache around each of the get functions just in case it is called multiple times. @ktlim can you see a downside for doing that?
There was a problem hiding this comment.
Altough there is a special case of the routine that gets the python packages since that only reports packages that have been loaded so if you call it, then do an import, then call it again, you will get a different answer. That won't be a problem for the Conda stuff or, I imagine, the EUPS one.
| # info_json = run_command(Commands.INFO, "--json") | ||
| # As a comporomise look for the env name in the path to the python | ||
| # executable | ||
| match = re.search(r"/envs/(.*?)/bin/", sys.executable) |
There was a problem hiding this comment.
I have tried to see if there was a slightly more elegant way of doing this without much luck. This may be about as good as it gets, unfortunately. Conda does seem to know some information about the environment(s) was activated, but I wasn't able to find a much better way than this.
Those should not change during run time.
|
@brianv0 I added a cache for the conda and eups results. |
No description provided.