Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30967: Fix segfault due to MKL #55

Merged
merged 1 commit into from Jul 1, 2021
Merged

DM-30967: Fix segfault due to MKL #55

merged 1 commit into from Jul 1, 2021

Conversation

PaulPrice
Copy link
Contributor

No description provided.

@PaulPrice PaulPrice requested a review from timj July 1, 2021 15:14
@PaulPrice
library: use RTLD_NOW instead of RTLD_LAZY
2554939 
RTLD_LAZY is not initialising libraries, particularly in the
case of libiomp5 and calling omp_get_max_threads, resulting
in segfaults. Replacing with RTLD_NOW ensures proper
initialisation.
timj
timj approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this is not going to slow things down much compared to the time it takes to import all the python code...

@PaulPrice PaulPrice merged commit 949febb into master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PaulPrice @timj