DM-33280: Turn Packages into a Mapping #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is "a wrapper around a dict", can't it just inherit from one? It doesn't seem like anyone's supposed to actually construct it with any other kind of |
ktlim
approved these changes
Jan 19, 2022
timj
changed the title
ktlim
approved these changes
Jan 27, 2022
This allows for the removal of a lot of compatibility methods. We likely don't the _names optimization given that dict keys are now set-like.
timj
force-pushed
the
tickets/DM-33280
branch
from
f2583da
to
38b4bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.