Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34689: Add run of GenerateHipsTask. #28

Merged
merged 1 commit into from Aug 17, 2022
Merged

DM-34689: Add run of GenerateHipsTask. #28

merged 1 commit into from Aug 17, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Jul 28, 2022

No description provided.

@erykoff erykoff changed the title DM-34689: Add run of HipsGenerationTask. DM-34689: Add run of GenerateHipsTask. Jul 28, 2022
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests, but I see that main does have something that purports to be a test so I'm not sure what that's testing.

python: |
config.properties.creator_did_template = "temp://lsst/ci_imsim/hips/images/band_{band}"
config.properties.obs_title_template = "CI imSim for band {band}"
config.properties.obs_description_template = "Coadded data from ci_imsim, band {band}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to test that any of the values from this config made it into a HiPS output file?

@erykoff erykoff merged commit 8d44a37 into main Aug 17, 2022
@erykoff erykoff deleted the tickets/DM-34689 branch August 17, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants