Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-9190: Cleanup pybind11 remaining code #11

Merged
merged 1 commit into from Apr 6, 2017
Merged

Conversation

pschella
Copy link

No description provided.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor requested addition.

@@ -19,7 +19,7 @@
# the GNU General Public License along with this program. If not,
# see <http://www.lsstcorp.org/LegalNotices/>.
#
from __future__ import division
from __future__ import absolute_import, division
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But please also append , print_function to make from __future__ import absolute_import, division, print_function if you are willing. That is our standard from __future__ import.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

In looking over the imports I realized that copyGoodPixels.h includes lsst/afw/image.h but never uses it. My mistake.

@pschella pschella merged commit f5c5ced into master Apr 6, 2017
@ktlim ktlim deleted the tickets/DM-9190 branch August 25, 2018 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants