Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-11162: Replace all use of Coord and subclasses with SpherePoint #15

Merged
merged 1 commit into from Mar 23, 2018

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Mar 16, 2018

by calling assertWcsAlmostEqualOverBBox instead of
using a custom method to do the same thing.
This eliminiates an issue with replacing Coord
with SpherePoint: calling getPosition without an argument.

by calling assertWcsAlmostEqualOverBBox instead of
using a custom method to do the same thing.
This eliminiates an issue with replacing Coord
with SpherePoint: calling getPosition without an argument.
Copy link

@rearmstr rearmstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification.

@r-owen r-owen merged commit f0963bb into master Mar 23, 2018
@ktlim ktlim deleted the tickets/DM-11162 branch August 25, 2018 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants