Review of DM-4373 (HSC backport: Add tract conveniences) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,3 +71,45 @@ class ExistingCoaddDataIdContainer(CoaddDataIdContainer): | |||
| def makeDataRefList(self, namespace): | |||
| super(ExistingCoaddDataIdContainer, self).makeDataRefList(namespace) | |||
| self.refList = [ref for ref in self.refList if ref.datasetExists()] | |||
|
|
|||
| class TractDataIdContainer(CoaddDataIdContainer): | |||
There was a problem hiding this comment.
Do we need this? It's not used anywhere in the stack and it comes with no tests, so it seems like we're just adding debt with no concrete gains.
There was a problem hiding this comment.
It is used several times in @PaulPrice's analysis script.
The use of deepCoadd (well, the "deep" part was configurable) was hard-coded, but we now write background-subtracted coadds as deepCoadd_calexp since HSC-1311. Changed CoaddDataIdContainer.makeDataRefList to respect the provided dataset type instead of always grabbing deepCoadd. However, the skymap doesn't have the same flexibility, and is always deepCoadd_skyMap, so simplified the parameter list. Conflicts: python/lsst/pipe/tasks/coaddBase.py This is essentially a cherry-pick of HSC-1366's: HyperSuprime-Cam/pipe_tasks@ea5e1ec Noting that the coaddDataIdContainer lives in coadd_utils in the LSST stack. Note also that HSC-1311 will be ported subsequently.
It is difficult to make a data reference that merely points to an entire tract: there is no data product solely at the tract level. This adds a TractDataIdContainer which generates a list of data references for patches within a given tract. Note that TractDataIdContainer was introduced in HSC's standalone commit: HyperSuprime-Cam/hscPipe@4a84654 It was added to HSC's python/hsc/pipe/tasks/stack.py task which does not exist in the LSST stack, so it was added to coadd_utils here in the file which also contains CoaddDataIdContainer.
laurenam
force-pushed
the
u/lauren/DM-4373
branch
from
0af7bbe
to
acbf38e
Compare
|
|
||
| if "tract" in dataId: | ||
| tractId = dataId["tract"] | ||
| tractRefs = defaultdict(list) |
There was a problem hiding this comment.
You probably want to remove this line from the loop, and instead use it as a replacement for line 91.
Make use of defaultdict and formatting updates.
laurenam
force-pushed
the
u/lauren/DM-4373
branch
from
acbf38e
to
5c0c45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.