Skip to content

Commit

Permalink
Merge pull request #209 from lsst/tickets/DM-40500
Browse files Browse the repository at this point in the history
DM-40500: remove now-unnecessary lookupFunctions.
  • Loading branch information
TallJimbo committed Aug 30, 2023
2 parents f902d2f + bc7839e commit 857a341
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 103 deletions.
74 changes: 0 additions & 74 deletions python/lsst/cp/pipe/_lookupStaticCalibration.py

This file was deleted.

3 changes: 0 additions & 3 deletions python/lsst/cp/pipe/cpFlatNormTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
from lsst.ip.isr.vignette import maskVignettedRegion
from lsst.cp.pipe.utils import ddict2dict

from ._lookupStaticCalibration import lookupStaticCalibration

__all__ = ["CpFlatMeasureTask", "CpFlatMeasureTaskConfig",
"CpFlatNormalizationTask", "CpFlatNormalizationTaskConfig"]

Expand Down Expand Up @@ -153,7 +151,6 @@ class CpFlatNormalizationConnections(pipeBase.PipelineTaskConnections,
doc="Input camera to use for gain lookup.",
storageClass="Camera",
dimensions=("instrument",),
lookupFunction=lookupStaticCalibration,
isCalibration=True,
)

Expand Down
2 changes: 0 additions & 2 deletions python/lsst/cp/pipe/cpSkyTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from lsst.pipe.tasks.background import (FocalPlaneBackground, MaskObjectsTask, SkyMeasurementTask,
FocalPlaneBackgroundConfig)
from lsst.daf.base import PropertyList
from ._lookupStaticCalibration import lookupStaticCalibration
from .cpCombine import CalibCombineTask

__all__ = ['CpSkyImageTask', 'CpSkyImageConfig',
Expand All @@ -49,7 +48,6 @@ class CpSkyImageConnections(pipeBase.PipelineTaskConnections,
doc="Input camera to use for geometry.",
storageClass="Camera",
dimensions=("instrument",),
lookupFunction=lookupStaticCalibration,
isCalibration=True,
)

Expand Down
7 changes: 0 additions & 7 deletions python/lsst/cp/pipe/defects.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
from lsst.ip.isr import Defects, countMaskedPixels
from lsst.pex.exceptions import InvalidParameterError

from ._lookupStaticCalibration import lookupStaticCalibration


class MeasureDefectsConnections(pipeBase.PipelineTaskConnections,
dimensions=("instrument", "exposure", "detector")):
Expand All @@ -61,7 +59,6 @@ class MeasureDefectsConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

outputDefects = cT.Output(
Expand Down Expand Up @@ -624,7 +621,6 @@ class MeasureDefectsCombinedConnections(MeasureDefectsConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

outputDefects = cT.Output(
Expand Down Expand Up @@ -666,7 +662,6 @@ class MeasureDefectsCombinedWithFilterConnections(MeasureDefectsCombinedConnecti
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

outputDefects = cT.Output(
Expand Down Expand Up @@ -707,7 +702,6 @@ class MergeDefectsConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

mergedDefects = cT.Output(
Expand Down Expand Up @@ -897,7 +891,6 @@ class MergeDefectsCombinedConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

mergedDefects = cT.Output(
Expand Down
3 changes: 0 additions & 3 deletions python/lsst/cp/pipe/deferredCharge.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
from lsst.ip.isr import DeferredChargeCalib, SerialTrap
from lmfit import Minimizer, Parameters

from ._lookupStaticCalibration import lookupStaticCalibration


class CpCtiSolveConnections(pipeBase.PipelineTaskConnections,
dimensions=("instrument", "detector")):
Expand All @@ -56,7 +54,6 @@ class CpCtiSolveConnections(pipeBase.PipelineTaskConnections,
doc="Camera geometry to use.",
storageClass="Camera",
dimensions=("instrument", ),
lookupFunction=lookupStaticCalibration,
isCalibration=True,
)

Expand Down
2 changes: 0 additions & 2 deletions python/lsst/cp/pipe/linearity.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from lsst.ip.isr import (Linearizer, IsrProvenance)

from .utils import funcPolynomial, irlsFit, AstierSplineLinearityFitter
from ._lookupStaticCalibration import lookupStaticCalibration


def ptcLookup(datasetType, registry, quantumDataId, collections):
Expand Down Expand Up @@ -91,7 +90,6 @@ class LinearitySolveConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

inputPtc = cT.PrerequisiteInput(
Expand Down
2 changes: 0 additions & 2 deletions python/lsst/cp/pipe/makeBrighterFatterKernel.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

from lsst.ip.isr import (BrighterFatterKernel)
from .utils import (funcPolynomial, irlsFit)
from ._lookupStaticCalibration import lookupStaticCalibration


class BrighterFatterKernelSolveConnections(pipeBase.PipelineTaskConnections,
Expand All @@ -52,7 +51,6 @@ class BrighterFatterKernelSolveConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)
inputPtc = cT.PrerequisiteInput(
name="ptc",
Expand Down
3 changes: 0 additions & 3 deletions python/lsst/cp/pipe/measureCrosstalk.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
from lsst.cp.pipe.utils import (ddict2dict, sigmaClipCorrection)
from lsst.meas.algorithms import SubtractBackgroundTask

from ._lookupStaticCalibration import lookupStaticCalibration

__all__ = ["CrosstalkExtractConfig", "CrosstalkExtractTask",
"CrosstalkSolveTask", "CrosstalkSolveConfig"]

Expand Down Expand Up @@ -351,7 +349,6 @@ class CrosstalkSolveConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument",),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

outputCrosstalk = cT.Output(
Expand Down
2 changes: 0 additions & 2 deletions python/lsst/cp/pipe/pdCorrection.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import lsst.pipe.base.connectionTypes as cT

from lsst.ip.isr import (PhotodiodeCorrection, IsrProvenance)
from ._lookupStaticCalibration import lookupStaticCalibration

__all__ = ["PhotodiodeCorrectionTask", "PhotodiodeCorrectionConfig"]

Expand All @@ -39,7 +38,6 @@ class PhotodiodeCorrectionConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument", ),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)

inputPtc = cT.PrerequisiteInput(
Expand Down
2 changes: 0 additions & 2 deletions python/lsst/cp/pipe/ptc/cpPlotPtcTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import lsst.pex.config as pexConfig
import lsst.pipe.base as pipeBase
import lsst.pipe.base.connectionTypes as cT
from lsst.cp.pipe._lookupStaticCalibration import lookupStaticCalibration

from lsst.cp.pipe.utils import (
funcAstier,
Expand All @@ -57,7 +56,6 @@ class PlotPhotonTransferCurveConnections(
storageClass="Camera",
dimensions=("instrument",),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)
# ptcFitType = "FULLCOVARIANCE" produces 12 plots
ptcPlot1 = cT.Output(
Expand Down
3 changes: 0 additions & 3 deletions python/lsst/cp/pipe/ptc/cpSolvePtcTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@

from lsst.ip.isr import PhotonTransferCurveDataset

from lsst.cp.pipe._lookupStaticCalibration import lookupStaticCalibration

import copy


Expand All @@ -59,7 +57,6 @@ class PhotonTransferCurveSolveConnections(pipeBase.PipelineTaskConnections,
storageClass="Camera",
dimensions=("instrument",),
isCalibration=True,
lookupFunction=lookupStaticCalibration,
)
outputPtcDataset = cT.Output(
name="ptcDatsetProposal",
Expand Down

0 comments on commit 857a341

Please sign in to comment.