Tickets/dm 11479 #1
Conversation
.gitignore
Outdated
| *.so | ||
| *.cfgc | ||
| *.pyc | ||
| *_wrap.cc |
There was a problem hiding this comment.
Can drop *_wrap.cc --- that's SWIG.
.gitignore
Outdated
| *.cfgc | ||
| *.pyc | ||
| *_wrap.cc | ||
| *Lib.py |
There was a problem hiding this comment.
Another SWIG-specific extension.
| @@ -0,0 +1,22 @@ | |||
| # | |||
There was a problem hiding this comment.
Why is everything preceded by a # as if this were python code?
There was a problem hiding this comment.
This comes straight from the LSST template repo. I think it's to facilitate pasting into python files, but I see no harm in keeping it as-is.
README
Outdated
| @@ -0,0 +1,11 @@ | |||
| =============================================================================== | |||
There was a problem hiding this comment.
Why not use README.md? GitHub likes that.
examples/SConscript
Outdated
| @@ -0,0 +1,3 @@ | |||
| # -*- python -*- | |||
There was a problem hiding this comment.
Suggest dumping this file unless there's anything in the examples directory.
python/lsst/cp/pipe/cpTask.py
Outdated
| # pair-number is kept, so we have to resolve links and pass in the *original* paths here :( | ||
| # Also, there is no "flat-pair" test type, so all FLAT/FLAT imType/testType will appear here | ||
| # so we need to filter these for only the pair acquisitions (as the eotest code looks like it | ||
| # isn't totally thorough on rejecting the wrong types of data here) |
There was a problem hiding this comment.
Can the camera team be persuaded to write the required data in the header?
You should explain what you mean by the "original" filename. I think you mean the filename written by the data acquisition system, which gets changed when we ingest into the data repo?
There was a problem hiding this comment.
Why do you need to rely on "flat1" and "flat2"? Can't you figure out pairs using the exposure time or something like that?
There was a problem hiding this comment.
The camera team can't change anything, they are in "production mode" and nothing will be changed at this point.
I have improved the explanation of what is meant by "original filename".
You could indeed work it out like that, but that is not how the 3rd party code works, and this code just exists to feed those tasks.
| import lsst.cp.pipe as cpPipe | ||
|
|
||
| @unittest.skipIf(noEotest, noEotestMsg) | ||
| def testClassInstantiation(self): |
There was a problem hiding this comment.
You test for instantiation, but don't actually run anything? I guess that's better than nothing, but not by much.
There was a problem hiding this comment.
Yeah, I know, it's just really hard to run anything without a ton of test data, so I spoke to some locals and we thought that at least setting things up was better than nothing.
ups/cp_pipe.build
Outdated
| @@ -0,0 +1,2 @@ | |||
| @LSST BUILD@ | |||
| build_lsst @PRODUCT@ @VERSION@ @REPOVERSION@ | |||
There was a problem hiding this comment.
You can dump this file --- it's not used any more.
ups/cp_pipe.cfg
Outdated
| # table files. | ||
| dependencies = { | ||
| "required": ["utils", "ndarray"], | ||
| "buildRequired": ["boost_test", "pybind11", "ndarray", "pex_exceptions"], |
There was a problem hiding this comment.
You need to revise these lists. Only include those that you use directly.
There was a problem hiding this comment.
Sorry about this, this is another instance of our template package misleading people.
ups/cp_pipe.table
Outdated
| setupRequired(boost >= 1.47.0) | ||
| setupRequired(utils >= 4.6.0.0) | ||
| setupRequired(pex_exceptions >= 4.6.0.0) | ||
| setupRequired(ndarray) |
There was a problem hiding this comment.
You need to revise the list of packages you require. Only include those that you use directly.
Get rid of the >= and everything following.
Add a method to run the eotest analysis using a butler. This ticket is just to make eotest directly runnable for the TS8 data. More work will follow to port the algorithms in eotest into the stack, and make stack-compliant subTasks to do this work inside this task.
mfisherlevine
force-pushed
the
tickets/DM-11479
branch
from
2646853
to
02502b8
Compare
No description provided.