Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31306: Create single SAL script that produces biases, darks, and flats #102

Merged
merged 1 commit into from Sep 29, 2021
Merged

DM-31306: Create single SAL script that produces biases, darks, and flats #102

merged 1 commit into from Sep 29, 2021

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Sep 28, 2021

No description provided.

@plazas plazas requested a review from czwa September 28, 2021 20:04
czwa
czwa approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using lower-case booleans in all pipeline yaml definitions for consistency. Other than that, as long as a test confirms it does what you want, it looks fine to me.

@plazas plazas merged commit 88fff79 into master Sep 29, 2021
@plazas plazas deleted the tickets/DM-31306 branch September 29, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plazas @czwa