Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31896: Clarify PTC code #112

Merged
merged 21 commits into from
Feb 1, 2022
Merged

DM-31896: Clarify PTC code #112

merged 21 commits into from
Feb 1, 2022

Commits on Jan 21, 2022

  1. Add more comments to cpExtractPtcTask to clarify

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    ec126f5 View commit details
    Browse the repository at this point in the history

  2. Add clarifications to docstrings in solve task

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    1d02d14 View commit details
    Browse the repository at this point in the history

  3. Wrap fitting functions for clarity 

    Change fitting functions names in tests
    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    9cae7f5 View commit details
    Browse the repository at this point in the history

  4. Remove one-liner chi2() method

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3241d16 View commit details
    Browse the repository at this point in the history

  5. Delete unused functions 

    Fix typos
    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    595fc1e View commit details
    Browse the repository at this point in the history

  6. Get rid of FitParameters

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    b3712b4 View commit details
    Browse the repository at this point in the history

  7. Eliminate parseData function

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    cbc6758 View commit details
    Browse the repository at this point in the history

  8. Pass bool for b=0 in fullCov fit

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8c978bf View commit details
    Browse the repository at this point in the history

  9. Delete and rename functions

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a55d105 View commit details
    Browse the repository at this point in the history

  10. Delete astierCovPtcUtils

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    824a751 View commit details
    Browse the repository at this point in the history

  11. Delete astierCovPtcFit 

    Fix bugs

Clarify docstrings
    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    ca25e9a View commit details
    Browse the repository at this point in the history

  12. Delete unused params from imsim ptc yaml file

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8987480 View commit details
    Browse the repository at this point in the history

  13. Set EXPAPPROXIMATION as default fit

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d4362f4 View commit details
    Browse the repository at this point in the history

  14. Move warning line into log message

    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    7313a77 View commit details
    Browse the repository at this point in the history

  15. Don't do fits if amp is BAD 

    Fix typo
    @plazas
    plazas committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    4b8ae8b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Fix typos in docstrings

    @plazas
    plazas committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    201d949 View commit details
    Browse the repository at this point in the history

  2. Delete gen2 plotting script

    @plazas
    plazas committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    43a44d6 View commit details
    Browse the repository at this point in the history

  3. Delete unused gen2 util functions

    @plazas
    plazas committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    a794b4f View commit details
    Browse the repository at this point in the history

  4. Delete covariance method in real space

    @plazas
    plazas committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    312e0ae View commit details
    Browse the repository at this point in the history

  5. Make makeCovArray part of PTC extract task

    @plazas
    plazas committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    ddbe5ec View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Simplify conditional to store fit results 

    Fix typos
    @plazas
    plazas committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    14b38e8 View commit details
    Browse the repository at this point in the history