Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33041: Rename output to correctly match calib type #115

Merged
merged 2 commits into from Jan 7, 2022
Merged

DM-33041: Rename output to correctly match calib type #115

merged 2 commits into from Jan 7, 2022

Conversation

mfisherlevine
Copy link
Collaborator

No description provided.

@mfisherlevine mfisherlevine marked this pull request as draft December 22, 2021 22:02
@mfisherlevine mfisherlevine marked this pull request as ready for review January 6, 2022 01:21
craiglagegit
craiglagegit reviewed Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@craiglagegit craiglagegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I admit I don't fully understand the connections that generate the documentation. In reality, the only change I made to get it all to run was the change to pipelines/cpLinearitySolve.yaml .

czwa
czwa approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also did a local build of pipelines_lsst_io to check the doc changes.

@mfisherlevine mfisherlevine merged commit 24727e6 into main Jan 7, 2022
@mfisherlevine mfisherlevine deleted the tickets/DM-33041 branch January 7, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiglagegit craiglagegit craiglagegit left review comments

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfisherlevine @craiglagegit @czwa