Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32746: Two amps in LSSTCam showed poor PTC curve fits. #117

Merged
merged 3 commits into from Jan 21, 2022

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Jan 20, 2022

No description provided.

@plazas plazas requested a review from czwa January 20, 2022 02:01
Fix bug in config file
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment on comments.

pivotIndex = np.min(np.where(np.diff(pivotList) == 1)[0])
pivot = pivotList[pivotIndex]
goodPoints[pivot+1:] = False
for k, g in groupby(enumerate(pivotList), lambda x: x[0]-x[1]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this have a quick comment describing what it's doing? I think I follow along, but even just a per-line # Find all indices in this group kind of thing would clarify what's happening.

@plazas plazas merged commit f5b6c0d into main Jan 21, 2022
@plazas plazas deleted the tickets/DM-32746 branch January 21, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants