DM-33138: Add CTI correction to ip_isr #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-33138
branch
from
60eb548
to
b5e1530
Compare
| overscan2 = data[:, 1] | ||
| test = (np.array(overscan1) + np.array(overscan2))/(nCols*np.array(signal)) | ||
| testResult = np.median(test) > 5.E-6 | ||
| self.log.info("Estimate of CTI test is %f for amp %s, %s.", np.median(test), ampName, |
There was a problem hiding this comment.
I see three % on this line and only two variables after the string closes. This is why I hate this kind of formatting and think we've got it all wrong, as this sort of mistake can't happen with f-strings. Am I misreading this due to my inexperience with this type of formatting, or is that an error?
There was a problem hiding this comment.
Oh god, it's the following string that's being added in with that last arg 😳
There was a problem hiding this comment.
Sorry for the noise, but this is why I hate this way of doing things.
There was a problem hiding this comment.
TBH, what I really wanted to write was testResult ? str1 : str2, but that's not valid python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a task to construct a CTI dataset from the set of measurements created by
ip_isr.