DM-34922: Report ptc turnoff in ptcDataset from cpPtcSolve #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
May 25, 2022
|
|
||
| # Save the point where the variance starts decreasing as the | ||
| # PTC turnoff point | ||
| ptcTurnoff = meanVecOriginal[goodPoints][-1] |
There was a problem hiding this comment.
Do you need to check that there more than zero goodPoints? Otherwise this will throw an IndexError.
There was a problem hiding this comment.
Good catch. I think goodPoints will always be the same length as meanVecOriginal, but it could be that all its points are False, so this would fail. We do check for that possibility a few lines below and declare the amp as bad if it happens, so I will move these lines with the turnoff after that check is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.