New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35316: Add 'detector' information (and any other missing info) to PTC dataset metadata #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If inputExpList
is truly unused now, it should be fully removed from run
(and this is fine once that's done). Otherwise, there needs to be some change so that it's used in the method.
@@ -187,10 +187,11 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
Output data refs to persist. | |||
""" | |||
inputs = butlerQC.get(inputRefs) | |||
outputs = self.run(inputCovariances=inputs['inputCovariances'], camera=inputs['camera']) | |||
detId = inputRefs.inputCovariances[0].dataId['detector'] | |||
outputs = self.run(inputCovariances=inputs['inputCovariances'], camera=inputs['camera'], detId=detId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need to pass inputExpList
? It didn't previously it seems, but doesn't that mean that it's always None
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it only being used to find a detector before, and now that's being handled by the dimension information in runQuantum
, so it isn't needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it was used before (except for that one check, but then it was always None
), so I removed it.
@@ -201,7 +202,10 @@ def run(self, inputCovariances, camera=None, inputExpList=None): | |||
Input camera. | |||
inputExpList : `list` [`~lsst.afw.image.ExposureF`], optional | |||
List of exposures. | |||
|
|||
detId : `int` | |||
Detector ID to locate the detector in teh camera and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
No description provided.