Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35807: expIdMasks in PTC dataset is an array of floats and not booleans when ptcFitType=FULLCOVARIANCE #143

Merged
merged 1 commit into from
Aug 3, 2022
Merged

DM-35807: expIdMasks in PTC dataset is an array of floats and not booleans when ptcFitType=FULLCOVARIANCE #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/lsst/cp/pipe/ptc/cpSolvePtcTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ def fitDataFullCovariance(self, dataset):
dataset.covariancesModelNoB[ampName] = listNanMatrix
dataset.aMatrixNoB[ampName] = nanMatrix

dataset.expIdMask[ampName] = np.repeat(np.nan, lenInputTimes)
dataset.expIdMask[ampName] = np.repeat(False, lenInputTimes)
dataset.gain[ampName] = np.nan
dataset.gainErr[ampName] = np.nan
dataset.noise[ampName] = np.nan
Expand Down Expand Up @@ -440,8 +440,10 @@ def fitDataFullCovariance(self, dataset):
dataset.ptcFitParsError[ampName] = [np.nan]
dataset.ptcFitChiSq[ampName] = np.nan

# Save full covariances, covariances models, and their weights
# dataset.expIdMask is already full
# Save full covariances, covariances models, and their weights.
# dataset.expIdMask is already full, but needs to be
# converted to bool.
dataset.expIdMask[ampName] = np.array(dataset.expIdMask[ampName], dtype=bool)
dataset.covariances[ampName] = covAtAmp
dataset.covariancesModel[ampName] = self.evalCovModel(muAtAmp,
fitResults['fullModel']['a'],
Expand Down