Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35569: ip_isr doEmpiricalReadNoise fails if an amplifier is fully masked #153

Merged
merged 1 commit into from Sep 15, 2022
Merged

DM-35569: ip_isr doEmpiricalReadNoise fails if an amplifier is fully masked #153

merged 1 commit into from Sep 15, 2022

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Sep 9, 2022

Move countMaskedPixels to ip_isr.

@czwa czwa requested a review from plazas September 9, 2022 20:35
plazas
plazas approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@plazas plazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cp_pipe/utils.py only had this one test. Do we need more unit tests for those utils? Just a general comment.

@czwa czwa merged commit 3900b83 into main Sep 15, 2022
@czwa czwa deleted the tickets/DM-35569 branch September 15, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plazas plazas plazas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @plazas