Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-36262: length of mask and covariance can disagree in BrighterFatterKernelSolveTask #154

Merged
merged 1 commit into from Sep 21, 2022
Merged

DM-36262: length of mask and covariance can disagree in BrighterFatterKernelSolveTask #154

merged 1 commit into from Sep 21, 2022

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Sep 20, 2022

Remove masking that appears unnecessary.

@czwa czwa requested a review from plazas September 20, 2022 20:32
plazas
plazas approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@plazas plazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix. I only wonder if we need to change the "raw" prefix in the name, as the PTC code has "raw" when a mask has not been applied.

@czwa czwa merged commit 6bae470 into main Sep 21, 2022
@czwa czwa deleted the tickets/DM-36262 branch September 21, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plazas plazas plazas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @plazas