Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18610: Update for cameraGeom API change. #16

Merged
merged 1 commit into from Nov 4, 2019
Merged

DM-18610: Update for cameraGeom API change. #16

merged 1 commit into from Nov 4, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Sep 25, 2019

getAmpInfoCatalog() -> getAmplifiers()

mfisherlevine
mfisherlevine reviewed Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could make the variable that it's assigned to something like amplifiers or amps as it will no longer be an ampInfoCatalog?

@czwa
Update for cameraGeom API change.
5544a48 
Use new `detector.getAmplifiers()` method instead of
`detector.getAmpInfoCat()`, and update instance names to reflect fact
that the new object is a list of `Amplifier`s.
@czwa czwa merged commit 5544a48 into master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisherlevine mfisherlevine mfisherlevine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @mfisherlevine