Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37376: Alternative method for identifying flat pairs for PTC analysis #163

Merged
merged 3 commits into from Jan 10, 2023

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Dec 19, 2022

No description provided.

@plazas plazas requested a review from czwa December 19, 2022 20:18
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

assert len(exposureList) == len(exposureIdList), "Different lengths for exp. list and exp. ID lists"
for expRef, expId in zip(exposureList, exposureIdList):
# Get flux from header, assuming it is in the metadata.
expFlux = expRef.get().getMetadata().toDict()[fluxKeyword]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly reference elements of the metadata: expRef.get().getMetadata[fluxKeyword].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably: expRef.get().getMetadata()[fluxKeyword]

@plazas plazas merged commit 69e9929 into main Jan 10, 2023
@plazas plazas deleted the tickets/DM-37376 branch January 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants