DM-37643: ci_cpp_gen3 fails on cpPtcExtract when noise is None #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-37643
branch
from
7f8815f
to
172b030
Compare
plazas
approved these changes
Jan 21, 2023
| @@ -756,9 +756,9 @@ def getGainFromFlatPair(self, im1Area, im2Area, imStatsCtrl, mu1, mu2, | |||
| if correctionType not in ['NONE', 'SIMPLE', 'FULL']: | |||
| raise RuntimeError("Unknown correction type: %s" % correctionType) | |||
|
|
|||
| if correctionType != 'NONE' and readNoise is None: | |||
| if correctionType != 'NONE' and not np.isfinite(readNoise): | |||
There was a problem hiding this comment.
Why np.isfinite instead of np.isnan? Just curious, I guess that, for this case, they work the same?
There was a problem hiding this comment.
No particular reason. isfinite catches other values that aren't plausible as well, but there are other impossible values (negative values). I'm going to leave it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NaN instead of None to prevent potential serialization issues.