DM-36390: calibrations should track sequencer crc #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,6 +162,7 @@ def run(self, inputExp, camera): | |||
| msg = "Found %s defects containing %s pixels in %s" | |||
| self.log.info(msg, len(defects), self._nPixFromDefects(defects), datasetType) | |||
|
|
|||
| defects.updateMetadataFromExposures([inputExp]) | |||
There was a problem hiding this comment.
General comment, not really for here, but why so few items? Don't we need this for biases, darks, flats etc? I see they're all being compared in isrTask.run() but are they being set correctly somewhere?
There was a problem hiding this comment.
These are merged in merge_headers for the bias, dark, and flat. For the IsrCalib based products, this call adds the header information from the exposure to the per-exposure defect set, which are then combined in the Merge task. I wanted to have a central method (this is part of the base class) to handle these keywords.
czwa
force-pushed
the
tickets/DM-36390
branch
from
36af39c
to
b6fe554
Compare
czwa
force-pushed
the
tickets/DM-36390
branch
from
b6fe554
to
8dd4c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add updateMetadataFromExposures calls.