DM-38309: Update to use new PhotonTransferCurveDataset internal format. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
reviewed
Mar 21, 2023
| # raise if this is not the case. | ||
| if covArray.shape[0] != 1: | ||
| raise RuntimeError("Serious programming error in covArray shape.") | ||
|
|
||
| covSqrtWeights = np.nan_to_num(1./np.sqrt(vcov)) | ||
|
|
||
| # Correct covArray for sigma clipping: | ||
| # 1) Apply varFactor twice for the whole covariance matrix | ||
| covArray *= varFactor**2 | ||
| # 2) But, only once for the variance element of the | ||
| # matrix, covArray[0,0] (so divide one factor out). |
plazas
reviewed
Mar 21, 2023
tests/test_ptc.py
Outdated
| @@ -96,6 +95,7 @@ def setUp(self): | |||
|
|
|||
| # create fake PTC data to see if fit works, for one amp ('amp') | |||
| self.flux = 1000. # ADU/sec | |||
| # FIXME try reversing this | |||
There was a problem hiding this comment.
What does this comment mean?
There was a problem hiding this comment.
Oh, I wanted to see what happens if we reverse the timeVec, I forgot to do that. The problem is that the code that sorts the time vector is untested.
plazas
approved these changes
Mar 21, 2023
czwa
approved these changes
Mar 21, 2023
erykoff
force-pushed
the
tickets/DM-38309
branch
from
070dfe7
to
c2e90bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also moves a couple of tests to ip_isr where they are closer to the code they are testing, in addition to fixing an index error.