DM-38826: ZeroDivisionError in lsst.cp.pipe.defects.MeasureDefectsCombinedWithFilterTask #184
Conversation
| y = self.defaultConfig.nPixBorderLeftRight | ||
| shapeY, shapeX = exp.image.array.shape | ||
| width, height = shapeX - 2*x, shapeY - 2*x | ||
| shouldBeFound = [Box2I(corner=Point2I(x, y), dimensions=Extent2I(width, height))] |
There was a problem hiding this comment.
So this is supposed to find all defects in this case? Shouldn't it find none?
There was a problem hiding this comment.
I found out empirically by running this test that it is declaring the whole detector as a defect (one box). I could only do it perhaps for just one amp?
There was a problem hiding this comment.
I think we want it to mask out one amp, and then I think it should return no defects, at least through this code path. Can you figure out where it's marking everything as a defect?
There was a problem hiding this comment.
I think that's the footprint that the afw code returns with that sigma:
ipdb> footprintList [995488 peaks, area=1000486, centroid=(257.5, 2996)] ipdb> defects = Defects.fromFootprintList(footprintList) ipdb> defects.toDict() {'metadata': <lsst.daf.base.propertyContainer.propertyList.PropertyList object at 0x7f91b8103530>, 'x0': [7], 'y0': [2000], 'width': [502], 'height': [1993]}
The above is for amp C10 in the example that Jim paste din the ticket.
As for the unit test, I'll do it only for one amp.
There was a problem hiding this comment.
Okay, so that's not from afw, that's from the code that explicitly makes a bad amp if sigma=0.0. And that is currently the intended behavior, but we may revisit it. So this is actually fine as it is.
| @@ -650,8 +657,10 @@ def valueThreshold(self, fileType): | |||
| self.assertIn(expectedBBox, boxesMeasured) | |||
|
|
|||
| def test_valueThreshold(self): | |||
| for fileType in ['flat', 'flat']: | |||
| for fileType in ['dark', 'flat']: | |||
plazas
force-pushed
the
tickets/DM-38826
branch
from
eb4df94
to
205ffa4
Compare
Saturate an amp instead of the whole flat in test.
plazas
force-pushed
the
tickets/DM-38826
branch
from
205ffa4
to
6526798
Compare
No description provided.