DM-39048: Use Gaussian histogram KS-test for good point selection in PTC fit. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
May 9, 2023
plazas
reviewed
May 10, 2023
| chi2Dof : `float` | ||
| Chi-squared per degree of freedom of Gaussian fit. | ||
| kspValue : `float` | ||
| The KS test p-value for the Gaussian fit. |
There was a problem hiding this comment.
Could you comment in Notes on what values are expected for Gaussian distribution? Or what is the range of values considered in this code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to changing to the Gaussian histogram ks-test p-value for good point / turnoff selection, this PR also fixes a few other issues: