Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39167: Improve outlier rejection in PTC fitting and add additional tests. #193

Merged
merged 11 commits into from May 18, 2023
Merged

DM-39167: Improve outlier rejection in PTC fitting and add additional tests. #193

merged 11 commits into from May 18, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented May 15, 2023

This PR adds:

  • A revised implementation of the outlier rejection algorithm that correctly implements the original Digel eotest code where the initial fit is only on the lower flux points, to prevent high flux outliers from ruining the fit.
  • Additional tests of PTC dataset reordering and raw value invariance, and fixes for bugs that these tests uncovered.
  • Robustification of ks-test computation.
  • Update PTC turnoff point to be highest point after outlier rejection, and not before (following the original eotest code).

I also renamed the short-lived doLegacyTurnoffAndOutlierSelection to doLegacyTurnoffSelection because I updated the outlier rejection for both the legacy and updated versions.

@erykoff erykoff requested a review from czwa May 17, 2023 17:11
czwa
czwa approved these changes May 17, 2023
View reviewed changes
python/lsst/cp/pipe/ptc/cpSolvePtcTask.py Show resolved Hide resolved
tests/test_ptc.py Show resolved Hide resolved
tests/test_ptc.py Show resolved Hide resolved
@erykoff erykoff force-pushed the tickets/DM-39167 branch 3 times, most recently from 1f8ca46 to 61f9709 Compare May 18, 2023 15:05
erykoff added 11 commits May 18, 2023 14:15
@erykoff
Add more model samples to make ks test more robust.
9c47c69
@erykoff
Fix missing sorts on ks test Gaussian model values.
753a53e
@erykoff
Use copies to ensure raw values are not stomped on.
070d907
@erykoff
Move low-flux cut to solve from extract in test configs.
96b67d1
@erykoff
Add test for out-of-order inputs and ensure all raw variables are cor…
cdf1e1c 
…rect.
@erykoff
Implement Digel algorithm for iterative outlier rejection.
528a4c0 
This replaces the older algorithm which could get confused if
there were any points above the PTC turnoff in the initial fit.
@erykoff
Change PTC Turnoff to be highest legal point after outlier rejection.
7be3044
@erykoff
Change from KS test with sampling to 1-sided test with CDF.
c2db142
@erykoff
Add break to outlier rejection iterations if mask is unchanged.
8080d1f
@erykoff
Add earlier check for legal mean values.
dbc0508
@erykoff
Filter out warnings when Gaussian fit is very bad.
c49553a
@erykoff erykoff merged commit 3b71a9b into main May 18, 2023
1 check passed
@erykoff erykoff deleted the tickets/DM-39167 branch May 18, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @czwa