Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39140: add photodiode integration algorithm for use with CCOB #195

Merged
merged 1 commit into from
May 22, 2023
Merged

DM-39140: add photodiode integration algorithm for use with CCOB #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/lsst/cp/pipe/linearity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,17 @@ class LinearitySolveConfig(pipeBase.PipelineTaskConfig,
"TRIMMED_SUM": ("Use numpy's trapz integrator, clipping the "
"leading and trailing entries, which are "
"nominally at zero baseline level."),
"CHARGE_SUM": ("Treat the current values as integrated charge "
"over the sampling interval and simply sum "
"the values, after subtracting a baseline level."),
}
)
photodiodeCurrentScale = pexConfig.Field(
dtype=float,
doc="Scale factor to apply to photodiode current values for the "
"``CHARGE_SUM`` integration method.",
default=-1.0,
)
applyPhotodiodeCorrection = pexConfig.Field(
dtype=bool,
doc="Calculate and apply a correction to the photodiode readings?",
Expand Down Expand Up @@ -316,6 +325,7 @@ def run(self, inputPtc, dummy, camera, inputDims, inputPhotodiodeData=None,
expId = handle.dataId['exposure']
pd_calib = handle.get()
pd_calib.integrationMethod = self.config.photodiodeIntegrationMethod
pd_calib.currentScale = self.config.photodiodeCurrentScale
monDiodeCharge[expId] = pd_calib.integrate()[0]
if self.config.applyPhotodiodeCorrection:
abscissaCorrections = inputPhotodiodeCorrection.abscissaCorrections
Expand Down