Rewrite MeasurePhotonTransferCurveTask datatypes #21

mfisherlevine · 2019-12-05T23:20:10Z

No description provided.

Use a single data structure to hold both the intermediate data and the final results in a sensible format. Change how the exclusion of data points is handled to make it understandable and persistable, especially so that other tasks can use the outputs. Improve robustness of fitting for curves that fully turn over. Correctly seed the initial parameters for fits and add limits for fit params. Fix bugs in the output messages and their formatting. Fix several logic errors. Fix typo meaning that errors were incorrectly reported in plots. Update tests for new code structure. Remove dangerous use of default value in function arg Update weird/bad values used in tests

Remove the freeze() option, and the test for it.

python/lsst/cp/pipe/ptc.py

mfisherlevine added 5 commits December 5, 2019 20:05

Fix flake8 violations

3974b66

Fix typo, bad f-string, and accidental looping over statement

2db32b7

Fix bug for wrong shape of array when errors are infinite

23542ef

Fix another typo

7dc361c

mfisherlevine force-pushed the tickets/DM-22405 branch from 9778143 to cd879ce Compare December 5, 2019 23:53

mfisherlevine added 2 commits December 6, 2019 09:27

Fix plotting bug due to use of np.setdiff1d()

a088ed1

Change marker size in plots

a3c0a97

plazas approved these changes Dec 6, 2019

View reviewed changes

Restructure the PhotonTransferCurveDataset and remove kwargs

9148e14

Remove the freeze() option, and the test for it.

mfisherlevine force-pushed the tickets/DM-22405 branch from 2a4f0b5 to 9148e14 Compare December 6, 2019 17:32