Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38563: Compare LATISS Defects generated from combined images #212

Merged
merged 4 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions pipelines/Latiss/cpDarkSkipCosmics.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
description: Latiss dark calibration construction
instrument: lsst.obs.lsst.Latiss
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpDarkSkipCosmics.yaml
tasks:
isr:
class: lsst.ip.isr.IsrTask
config:
# Disable these until valid calibrations exist.
overscan.fitType: 'MEDIAN_PER_ROW'
doLinearize: false
doCrosstalk: false
doDefect: true
25 changes: 25 additions & 0 deletions pipelines/_ingredients/cpDarkSkipCosmics.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
description: cp_pipe DARK calibration construction
tasks:
isr:
class: lsst.ip.isr.IsrTask
config:
connections.ccdExposure: 'raw'
connections.outputExposure: 'cpDarkIsr'
doWrite: true
doBrighterFatter: false
doDark: false
doFlat: false
doApplyGains: false
doFringe: false
cpDarkCombine:
class: lsst.cp.pipe.cpCombine.CalibCombineTask
config:
connections.inputExpHandles: 'cpDarkIsr'
connections.outputData: 'dark'
calibrationType: 'dark'
exposureScaling: "DarkTime"
python: config.mask.append("CR")
contracts:
- isr.doDark == False
- cpDarkCombine.calibrationType == "dark"
- cpDarkCombine.exposureScaling == "DarkTime"
2 changes: 1 addition & 1 deletion python/lsst/cp/pipe/defects.py
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ class MergeDefectsCombinedConnections(pipeBase.PipelineTaskConnections,
)

mergedDefects = cT.Output(
name="defectsCombined",
name="defects",
doc="Final merged defects.",
storageClass="Defects",
dimensions=("instrument", "detector"),
Expand Down