DM-42024: Allow for low gains and allow initial outlier cutoff to have units of electrons. #222
Conversation
| @@ -1005,8 +1014,8 @@ def errFunc(p, x, y): | |||
| if self.config.binSize > 1: | |||
| bounds = self._boundsForAstier(parsIniPtc) | |||
| else: | |||
| bounds = self._boundsForAstier(parsIniPtc, lowers=[-1e-4, 0.5, -2000], | |||
There was a problem hiding this comment.
How necessary are these bounds for the convergence of this initial fit? In any case, I'm just wondering if even the new values (min=0.2, and max=3.0) will give us trouble in the future. Or if this code is used for other cameras with different settings (I think DECam has gains of 4, so I'm not even sure at this point how this has worked in the past for DECam...)
There was a problem hiding this comment.
I don't think anybody has ever run this on DECam. I'll change this to a bigger range.
| if self.config.scaleMaxSignalInitialPtcOutlierFit: | ||
| approxGain = np.nanmedian(meanVecOriginal/varVecOriginal) | ||
| maxADUInitialPtcOutlierFit = self.config.maxSignalInitialPtcOutlierFit/approxGain | ||
| self.log.info( |
There was a problem hiding this comment.
We were concerned in another ticket about too much info in the logs, especially per amp. Will it be OK in this case? Should we change the level to "debug"?
There was a problem hiding this comment.
I did think about this, and could make it debug. But it's not that much. The difference is that this is a log that is done per amp in a PTC fit (16 messages per hundreds of flat pairs) and not a log per amp per ISR (16 messages times hundreds of flat pairs).
erykoff
force-pushed
the
tickets/DM-42024
branch
from
ecab5b5
to
c0e6461
Compare
This fixes a bug where low gains (<0.5) were not allowed in the fit. It also now changes
maxADUInitialPtcOutlierFitto default of units of electrons that can then be scaled by an initial estimate of the gain. This allows the cutoff to be approximately invariant across a range of gain settings.