DM-42160: eo_pipe/cp_verify parity: dark #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
approved these changes
Jan 17, 2024
| @@ -612,6 +615,33 @@ def setFilter(exp, filterLabel): | |||
| """ | |||
| pass | |||
|
|
|||
| def calibStats(self, exp, calibrationType): | |||
There was a problem hiding this comment.
This could be a static method, I guess.
There was a problem hiding this comment.
Left alone, as this now uses a config parameter.
| metadata.set(f"LSST CALIB {calibrationType.upper()} {amp.getName()} DISTRIBUTION 84-PCT", p84) | ||
| metadata.set(f"LSST CALIB {calibrationType.upper()} {amp.getName()} DISTRIBUTION 95-PCT", p95) | ||
| metadata.set(f"LSST CALIB {calibrationType.upper()} {amp.getName()} DISTRIBUTION 100-PCT", p100) | ||
|
|
There was a problem hiding this comment.
Instead of hard-coding these, could we take the percentile values to compute as an input, and loop over those?
There was a problem hiding this comment.
You're right, hard coding this is likely to be annoying in the future. I've moved the percentile levels to a config option, and have this method zip the levels and measured values into a second loop. Then, if someone decides the quartiles are useful too, it's just a config change.
There was a problem hiding this comment.
PS metadata[key] = value should work fine.
czwa
force-pushed
the
tickets/DM-42160
branch
from
cb5a7d5
to
267548e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calibration distribution statistics.