DM-42163: eo_pipe/cp_verify parity: ptc #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
force-pushed
the
tickets/DM-42163
branch
from
cdad8a1
to
d94a2a4
Compare
czwa
approved these changes
Jan 19, 2024
| @@ -809,12 +816,15 @@ def measureMeanVarCov(self, im1Area, im2Area, imStatsCtrl, mu1, mu2): | |||
| Covariance at (dx, dy). | |||
| nPix : `int` | |||
| Number of pixel pairs used to evaluate var and cov. | |||
| rowMeanVariance : `float` or `NaN` | |||
There was a problem hiding this comment.
NaN is just a flavor of float.
|
|
||
| If either mu1 or m2 are NaN's, the returned value is NaN. | ||
| """ | ||
| if np.isnan(mu1) or np.isnan(mu2): | ||
| self.log.warning("Mean of amp in image 1 or 2 is NaN: %f, %f.", mu1, mu2) | ||
| return np.nan, np.nan, None | ||
| return np.nan, np.nan, None, np.nan |
There was a problem hiding this comment.
The test above (L587) tests for is None, not np.nan. Same point for the other returns below.
There was a problem hiding this comment.
Changed the test to check for np.nan
plazas
force-pushed
the
tickets/DM-42163
branch
from
2a531f7
to
c223992
Compare
added 5 commits
January 24, 2024 14:24
plazas
force-pushed
the
tickets/DM-42163
branch
from
c223992
to
c24e7b7
Compare
czwa
approved these changes
Jan 25, 2024
| self.log.warning("NaN mean or var, or None cov in amp %s in exposure pair %d, %d of " | ||
| if (np.isnan(muDiff) or np.isnan(varDiff) or (covAstier is None) | ||
| or (rowMeanVariance is np.nan)): | ||
| self.log.warning("NaN mean, var or rowmeanVariance, or None cov in amp %s " |
There was a problem hiding this comment.
"rowMeanVariance"? Just for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.