Fix PTC fit type #23
Merged
Fix PTC fit type #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Jan 14, 2020
| @@ -529,6 +529,8 @@ def runDataRef(self, dataRef, visitPairs): | |||
| ptcConfig = MeasurePhotonTransferCurveTaskConfig() | |||
| ptcConfig.isrForbiddenSteps = [] | |||
| ptcConfig.doFitBootstrap = True | |||
| ptcConfig.ptcFitType = 'POLYNOMIAL' # default Astier doesn't work for gain correction | |||
There was a problem hiding this comment.
I thought POLYNOMIAL was the default ptcFitType?
There was a problem hiding this comment.
Aaaargh, you're right, and therefore this doesn't fix the problem! 😩 Something is overriding that, need to hunt. Sorry for the premature review... 😔
mfisherlevine
force-pushed
the
tickets/DM-23073
branch
from
ad8c6de
to
74788e0
Compare
Also, ensure POLYNOMIAL is always used regardless of upstream default, and improve error message on failure.
mfisherlevine
force-pushed
the
tickets/DM-23073
branch
from
74788e0
to
558d81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.