Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43022: Refactor calibration and defect production to ensure masking is orthogonal to calibration frames. #235

Merged
merged 23 commits into from Mar 7, 2024
Merged

DM-43022: Refactor calibration and defect production to ensure masking is orthogonal to calibration frames. #235

merged 23 commits into from Mar 7, 2024

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Feb 29, 2024

No description provided.

czwa and others added 20 commits February 23, 2024 17:02
@czwa @erykoff
Do NOT exclude edge pixels when looking for defects.
7183db5
@czwa @erykoff
Fix incorrect defect configuration.
177897a
@erykoff
Change output of combine to use BAD mask plane by default.
44a8e23 
This also adds statistics on the number of BAD pixels per amplifier for the
combined calibration.
@erykoff
Update bias configurations to reduce masking.
44ea957
@erykoff
Turn off masking negative variance for bias creation.
7a367e6
@erykoff
Clear BAD mask plane from defects after CR finding.
c428f18
@erykoff
Update dark ISR settings.
8e00f16
@erykoff
Add new cpDarkForDefects pipeline definition.
e99dda9
@erykoff
Update flat configurations without masking.
ae82dad
@erykoff
Make the output dark type the usual name.
a652512
@erykoff
Properly implement config.edgesAsDefects for merge defects task.
3ac588a
@erykoff
Turn on edgesAsDefects for LATISS combined defects finding.
22df38b
@erykoff
Turn off interpolation for bias/dark production.
7062d03
@erykoff
Fix clearing of BAD mask plane in dark production.
5ac031b
@erykoff
Turn off bad region setting in bias/dark production.
aea00f7
@erykoff
Add combined bias to combined defect finding.
c281c27
@erykoff
Update default bad bias threshold.
25e16c6
@erykoff
Fix error log when there are NO_DATA pixels.
93855f9
@erykoff
Fix extraneous extra blank line.
fe0597e
@erykoff
Ensure flats do not have interpolation on.
ad6d281
czwa
czwa approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues.

python/lsst/cp/pipe/cpCombine.py Outdated Show resolved Hide resolved
pipelines/_ingredients/cpDarkForDefects.yaml Show resolved Hide resolved
python/lsst/cp/pipe/defects.py Show resolved Hide resolved
czwa
czwa approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had a "review changes since last view" button, and I'm still happy with this new view.

@erykoff erykoff merged commit 643244a into main Mar 7, 2024
2 checks passed
@erykoff erykoff deleted the tickets/DM-43022 branch March 7, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @czwa