Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43045: Stand-up per-camera cpSky configurations #236

Merged
merged 3 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions pipelines/HyperSuprimeCam/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,13 @@ description: Sky frame generation pipeline definition.
instrument: lsst.obs.subaru.HyperSuprimeCam
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml
tasks:
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values correspond to the HSC recommendation. As noted
# below, the sizes are in millimeters, and correspond to a
# background image of 8192x8192 pixels (8192*0.015=122.88).
largeScaleBackground.xSize: 122.88 # in mm
largeScaleBackground.ySize: 122.88 # in mm
largeScaleBackground.pixelSize: 0.015 # in mm per pixel
10 changes: 10 additions & 0 deletions pipelines/Latiss/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,13 @@ tasks:
doLinearize: false
doCrosstalk: true
doBrighterFatter: false
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values roughly equate to the dimensions of a single detector.
# As noted below, the sizes are in millimeters, and correspond to a
# background image of 4096*4096 pixels (4096*0.01=40.96).
# TODO: Revise these values on DM-43321.
largeScaleBackground.xSize: 40.96 # in mm
largeScaleBackground.ySize: 40.96 # in mm
largeScaleBackground.pixelSize: 0.01 # in mm per pixel
11 changes: 11 additions & 0 deletions pipelines/LsstCam/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,14 @@ description: Sky frame generation pipeline definition.
instrument: lsst.obs.lsst.LsstCam
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml
tasks:
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values roughly equate to the dimensions of a single detector.
# As noted below, the sizes are in millimeters, and correspond to a
# background image of 4096*4096 pixels (4096*0.01=40.96).
# TODO: Revise these values on DM-43321.
largeScaleBackground.xSize: 40.96 # in mm
largeScaleBackground.ySize: 40.96 # in mm
largeScaleBackground.pixelSize: 0.01 # in mm per pixel
11 changes: 11 additions & 0 deletions pipelines/LsstCamImSim/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,14 @@ description: Sky frame generation pipeline definition.
instrument: lsst.obs.lsst.LsstCamImSim
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml
tasks:
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values roughly equate to the dimensions of a single detector.
# As noted below, the sizes are in millimeters, and correspond to a
# background image of 4096*4096 pixels (4096*0.01=40.96).
# TODO: Revise these values on DM-43321.
largeScaleBackground.xSize: 40.96 # in mm
largeScaleBackground.ySize: 40.96 # in mm
largeScaleBackground.pixelSize: 0.01 # in mm per pixel
11 changes: 11 additions & 0 deletions pipelines/LsstComCam/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,14 @@ description: Sky frame generation pipeline definition.
instrument: lsst.obs.lsst.LsstComCam
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml
tasks:
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values roughly equate to the dimensions of a single detector.
# As noted below, the sizes are in millimeters, and correspond to a
# background image of 4096*4096 pixels (4096*0.01=40.96).
# TODO: Revise these values on DM-43321.
largeScaleBackground.xSize: 40.96 # in mm
largeScaleBackground.ySize: 40.96 # in mm
largeScaleBackground.pixelSize: 0.01 # in mm per pixel
11 changes: 11 additions & 0 deletions pipelines/LsstTS8/cpSky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,14 @@ description: Sky frame generation pipeline definition.
instrument: lsst.obs.lsst.LsstTS8
imports:
- location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml
tasks:
cpSkyImage:
class: lsst.cp.pipe.cpSkyTask.CpSkyImageTask
config:
# These values roughly equate to the dimensions of a single detector.
# As noted below, the sizes are in millimeters, and correspond to a
# background image of 4096*4096 pixels (4096*0.01=40.96).
# TODO: Revise these values on DM-43321.
largeScaleBackground.xSize: 40.96 # in mm
largeScaleBackground.ySize: 40.96 # in mm
largeScaleBackground.pixelSize: 0.01 # in mm per pixel
11 changes: 0 additions & 11 deletions python/lsst/cp/pipe/cpSkyTask.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,6 @@ class CpSkyImageConfig(pipeBase.PipelineTaskConfig,
doc="Large-scale background configuration.",
)

def setDefaults(self):
# These values correspond to the HSC recommendation. As noted
# below, the sizes are in millimeters, and correspond to an
# background image 8192x8192 pixels (8192*0.015=122.88).
self.largeScaleBackground.xSize = 122.88 # in mm
self.largeScaleBackground.ySize = 122.88 # in mm
self.largeScaleBackground.pixelSize = 0.015 # in mm per pixel
self.largeScaleBackground.minFrac = 0.1
self.largeScaleBackground.mask = ['BAD', 'SAT', 'INTRP', 'DETECTED', 'DETECTED_NEGATIVE',
'EDGE', 'NO_DATA']


class CpSkyImageTask(pipeBase.PipelineTask):
"""Mask the detections on the postISRCCD.
Expand Down