Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44025: Update ptc turnoff computation code and improve tests with real data. #240

Merged
merged 11 commits into from
Apr 26, 2024
Merged

DM-44025: Update ptc turnoff computation code and improve tests with real data. #240

merged 11 commits into from
Apr 26, 2024

Commits on Apr 23, 2024

  1. Add new configuration to reject bad PTC values.

    @erykoff
    erykoff committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e5fbc27 View commit details
    Browse the repository at this point in the history

  2. Add addtional tests for computing PTC turnoff, including real sample … 

    …data.
    @erykoff
    erykoff committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    848babd View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Add computation of ptcTurnoffSamplingError to ptc.

    @erykoff
    erykoff committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    947fe74 View commit details
    Browse the repository at this point in the history

  2. Override turnoff config for sparse linearity tests.

    @erykoff
    erykoff committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ed25a34 View commit details
    Browse the repository at this point in the history

  3. Add "downing dip" amplifier to sample data.

    @erykoff
    erykoff committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5ed276e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Ensure each amplifier is properly sorted in initial fit.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be7b853 View commit details
    Browse the repository at this point in the history

  2. Update ptc turnoff and error based on sorted values.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2f41576 View commit details
    Browse the repository at this point in the history

  3. Add additional sorting for good points.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f618a4c View commit details
    Browse the repository at this point in the history

  4. Add break to avoid additional unnecessary checks.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    822add5 View commit details
    Browse the repository at this point in the history

  5. Add specific messages for test failures.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a802bc3 View commit details
    Browse the repository at this point in the history

  6. Add warning if initial outlier fit has not converged.

    @erykoff
    erykoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    30067e9 View commit details
    Browse the repository at this point in the history