DM-23681: Check, in the unit tests, that fitPtcAndNonLinearity returns what it is supposed to return. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
reviewed
Mar 23, 2020
tests/test_ptc.py
Outdated
| @@ -95,50 +99,94 @@ def setUp(self): | |||
| self.dataset.rawExpTimes[ampName] = timeVec | |||
| self.dataset.rawMeans[ampName] = muVec | |||
|
|
|||
| def test_ptcFitQuad(self): | |||
| def ptcFitQuadAndCubic(self, order): | |||
There was a problem hiding this comment.
If you have to specify the order, it's not really QuadAndCubic but QuadOrCubic, right? :-)
More generally, I think I'd just call this fitAndCheckPtc or similar, rather than trying to specify the order of fitting in the function name.
tests/test_ptc.py
Outdated
| for ampName in self.ampNames: | ||
| localDataset.rawVars[ampName] = [self.noiseSq + self.c1*mu + self.c2*mu**2 + self.c3*mu**3 for | ||
| mu in localDataset.rawMeans[ampName]] | ||
| self.assertAlmostEqual('POLYNOMIAL', returnedDataset.ptcFitType[ampName]) |
There was a problem hiding this comment.
This has to be exactly equal, right? I'm not even sure what “almost equal” means for a string.
tests/test_ptc.py
Outdated
| self.assertTrue(localDataset.nonLinearityResiduals[ampName].all() == 0) | ||
| def test_ptcFitQuadAndCubic(self): | ||
| for order in [2, 3]: | ||
| self.ptcFitQuadAndCubic(order) | ||
|
|
||
| def test_ptcFitAstier(self): |
There was a problem hiding this comment.
Almost all of the changes in this function are a duplicate of those in ptcFitQuadAndCubic. Could you take this opportunity to combine them into one? It'd be a lot easier to see what was going on, and to make sure they are updated in sync in future!
plazas
force-pushed
the
tickets/DM-23681
branch
from
40eb018
to
3ad4601
Compare
jdswinbank
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.