DM-24556: Add normalize method to Defects #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,7 +131,6 @@ def check_maskBlocks(self, inputDefects, expectedDefects): | |||
| task = cpPipe.defects.FindDefectsTask(config=config) | |||
|
|
|||
| defectsWithColumns = task.maskBlocksIfIntermitentBadPixelsInColumn(inputDefects) | |||
|
|
|||
There was a problem hiding this comment.
As always, try not to do whitespace only changes.
| @@ -214,6 +213,7 @@ def test_maskBlocks_discontigous_to_single_block(self): | |||
| Box2I(corner=Point2I(30, 34), dimensions=Extent2I(1, 15))] | |||
| for badBox in badPixels: | |||
| defects.append(badBox) | |||
|
|
|||
Comment on lines
-351
to
-352
| Box2I(corner=Point2I(61, 2), dimensions=Extent2I(1, 12)), | ||
| Box2I(corner=Point2I(62, 2), dimensions=Extent2I(1, 12))] |
There was a problem hiding this comment.
Is there a reason this is being removed? I guess this comment applies to all the test changes. Presumably they're necessary, but could you briefly just explain why please?
There was a problem hiding this comment.
The expected defects before these changes where individual boxes, even if they were adjacent. With the changes, the boxes get merged into fewer boxes that have a wider extension (for example, 2 pixels in one direction instead of 1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.