DM-24756: Make sigma clipping configurable in PTC task #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
May 12, 2020
python/lsst/cp/pipe/ptc.py
Outdated
| @@ -145,6 +145,11 @@ class MeasurePhotonTransferCurveTaskConfig(pexConfig.Config): | |||
| doc="Sigma cut for outlier rejection in PTC.", | |||
| default=5.0, | |||
| ) | |||
| sigmaCutAfwMathStatsControl = pexConfig.Field( | |||
There was a problem hiding this comment.
This should probably be called somethingNumSigmaClip, so it's clear what the clipping is being applied to (the "something") and so it matches the name of the property set in the statsControl object.
There was a problem hiding this comment.
nSigmaClipPtc would, I think, be in keeping with our namings elsewhere.
python/lsst/cp/pipe/ptc.py
Outdated
| @@ -145,6 +145,11 @@ class MeasurePhotonTransferCurveTaskConfig(pexConfig.Config): | |||
| doc="Sigma cut for outlier rejection in PTC.", | |||
| default=5.0, | |||
| ) | |||
| sigmaCutAfwMathStatsControl = pexConfig.Field( | |||
| dtype=float, | |||
| doc="Sigma cut for afwMatch.StatisticsControl()", | |||
There was a problem hiding this comment.
I changed the name of the parameter to nSigmaClipPtc
There was a problem hiding this comment.
...but I did fix the typo in the docstring, thanks!
python/lsst/cp/pipe/ptc.py
Outdated
| sigmaCutAfwMathStatsControl = pexConfig.Field( | ||
| dtype=float, | ||
| doc="Sigma cut for afwMatch.StatisticsControl()", | ||
| default=3.0, |
There was a problem hiding this comment.
Can we change this to 5.5 please?
There was a problem hiding this comment.
On None and use the default if not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.