DM-23302: Add ci_cpp package to allow calibration product generation to be tested #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
reviewed
Aug 17, 2020
plazas
reviewed
Aug 17, 2020
plazas
reviewed
Aug 17, 2020
plazas
reviewed
Aug 18, 2020
mfisherlevine
approved these changes
Aug 20, 2020
Comment on lines
+70
to
+77
| certify = CertifyCalibration(butler=butler, | ||
| inputCollection=args.inputCollection, | ||
| outputCollection=args.outputCollection) | ||
|
|
||
| crozier.findInputs(args.datasetTypeName) | ||
| certify.findInputs(args.datasetTypeName) | ||
| if not args.skipCL: | ||
| crozier.addCalibrationLabel(beginDate=args.beginDate, endDate=args.endDate) | ||
| crozier.registerCalibrations(args.datasetTypeName) | ||
| certify.addCalibrationLabel(beginDate=args.beginDate, endDate=args.endDate) | ||
| certify.registerCalibrations(args.datasetTypeName) |
There was a problem hiding this comment.
certifier as a noun perhaps? Don't much care really as it's in a bin script though.
timj
reviewed
Aug 20, 2020
| @@ -67,11 +67,11 @@ | |||
| butler = Butler(args.root, run=args.inputCollection) | |||
There was a problem hiding this comment.
In the butler root above can you say "URI to butler" or something because it's not always a path.
|
As a general comment, we are trying to move away from lots of code in bin.src python scripts. They should follow the new approach where the bin.src just has two lines to call |
czwa
force-pushed
the
tickets/DM-23302
branch
2 times, most recently
from
781fe8e
to
bde7f37
Compare
czwa
force-pushed
the
tickets/DM-23302
branch
from
bde7f37
to
7952de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cpCertify for upstream API changes.
Fix errors detected by ci_cpp code.