DM-26595: Have cp_pipe/ptc.py continue if there is a bad flat pair #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update warning message
czwa
approved these changes
Sep 3, 2020
python/lsst/cp/pipe/ptc.py
Outdated
| dataRef.dataId['expId'] = v2 | ||
| exp2 = dataRef.get("postISRCCD", immediate=True) | ||
| except RuntimeError: | ||
| self.log.warn(f"postISR exposure for either visit {v1} or visit {v2} could not be retreived. " |
There was a problem hiding this comment.
This should probably not use "visit" anymore, as these should all be expId values now. There are a lot of them already in place, but we should at least not add any more.
| except RuntimeError: | ||
| self.log.warn(f"postISR exposure for either visit {v1} or visit {v2} could not be retreived. " | ||
| "Ignoring flat pair.") | ||
| continue |
There was a problem hiding this comment.
Does this pair show up as masked on ~L303? I'm trying to think if there are downstream issues due to dropping this pair.
There was a problem hiding this comment.
The skipped pair does not show up in the return of {{getVisitsUsed}} (as this function only returns those pairs that were used), so that means that it does show up as masked. Also, as you point out in Jira, the example in there runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.