tickets/DM-16295 - Get cp_pipe etc working for ts8 for bootcamp #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously hard-coded to 'ccd' but obs_lsst uses 'detector' so this is now configurable. Note that this take doesn't run from the command line so there is no point in adding a config file to obs_lsst as that magic is picked up by the argparser. Users will need to know to set this in the config by hand.
Clearly this isn't fatal as the code continues to run This doesn't change behaviour, just stops the code announcing things are fatal when they aren't.
TallJimbo
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
Looks good, though you may want to consider defining a couple of dataId variables up front that you can reuse elsewhere.
As an aside, all of the embedded Butler calls and changes in data ID keys within blocks of algorithmic code make me worried about the prospect of eventually refactoring this into a PipelineTask. We should talk about that at some point.
|
Yes, good point, on both counts. Let's discuss at some point, but I suspect the answer will be just to not do it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.